Aggregation of cosmetic changes made during work on REPL PRs: librustc #64227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Sep 6, 2019
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Sep 7, 2019
|
r=me with the 3 remaining comments addressed. |
|
@bors r=centril p=1 |
|
📌 Commit 30dd1a31784dbeba53aa153867470f576ad3bf32 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=0 |
|
☔ The latest upstream changes (presumably #64246) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
|
@bors r=centril |
|
📌 Commit fd48ca2 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 7, 2019
Aggregation of cosmetic changes made during work on REPL PRs: librustc Factored out from hacking on rustc for work on the REPL. r? @Centril
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 7, 2019
Aggregation of cosmetic changes made during work on REPL PRs: librustc Factored out from hacking on rustc for work on the REPL. r? @Centril
bors
added a commit
that referenced
this pull request
Sep 7, 2019
Rollup of 7 pull requests Successful merges: - #64023 (libstd fuchsia fixes) - #64098 (Ensure edition lints and internal lints are enabled with deny-warnings=false) - #64139 (Migrate internal diagnostic registration to macro_rules) - #64226 (Aggregation of cosmetic changes made during work on REPL PRs: libsyntax) - #64227 (Aggregation of cosmetic changes made during work on REPL PRs: librustc) - #64235 (Upgrade env_logger to 0.6) - #64258 (compiletest: Match suffixed environments) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out from hacking on rustc for work on the REPL.
r? @Centril